Re: emailval.js accepts incomplete email addresses
By: Codefenix to echicken on Sun Sep 01 2024 09:51 am

Re: emailval.js accepts incomplete email addresses
By: echicken to Codefenix on Sat Aug 31 2024 09:05 pm

If you *really* want to check if an email address is valid, then there's a whole rabbit hole of standards and regex fun you can go down. I have to wonder why/if this is even necessary in the context of email validation. If the email address is fucked, then the user will not get validated. If they want to gain access, they'll need to supply a working address. Sort of a self-solving problem right?

No, not quite. I must not have made it very clear in my initial post. The reason why I would want to "pre-validate" an email address is because someone entered an incomplete one on my system (user@gmail), and it broke the script because the script (incorrectly) treated the entry as though it were a QWKmail address. This let the user skip validation and proceed to main, when it should have screened them out instead.

I don't think that's how that script works though. It doesn't "screen people out" (that provide an invalid email address).
--
digital man (rob)

Sling Blade quote #6:
Karl: he should've had a chance to grow up. He would had fun some time.
Norco, CA WX: 88.4øF, 30.0% humidity, 1 mph NE wind, 0.00 inches rain/24hrs
---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: emailval.js accepts incomplete email addresses
By: Digital Man to Codefenix on Wed Sep 04 2024 10:05 pm

I don't think that's how that script works though. It doesn't "screen people out" (that provide an invalid email address).

The list of available options in the script's menu imply exactly that.

[S] Send validation code to <email address>
[V] Validate your account
[E] Edit/Update email address
[H] Hangup

If the sysop has the emailval module enabled, it gets called during logon. The user is meant to validate or hit the bricks.

There is no 5th option to proceed unvaliated, otherwise I could agree with you about the script's intent.

|01<|09co|03d|11e|15Ÿ|11e|03n|09ix|01>|07


...God made everything out of nothing. But the nothingness shows through.
---
þ Synchronet þ -=[ ConstructiveChaos BBS | conchaos.synchro.net ]=-

Re: emailval.js accepts incomplete email addresses
By: Codefenix to Digital Man on Thu Sep 05 2024 08:34:45

The user is meant to validate or hit the bricks.

There is no 5th option to proceed unvaliated, otherwise I could agree with you about the script's intent.

Thanks for explaining - I've been too lazy to actually look at the script so this clarifies things a bit.

I think this script probably needs a rewrite or significant revision.

- Permitted netmail types should be configurable and strings validated
- Block logon for unvalidated users should be optional
- On fatal error, should hang up or just exit depending on above setting

Seems like at the moment it has a poor failure mode and was written with a perplexing misunderstanding of newuser restrictions.

echicken
electronic chicken bbs - bbs.electronicchicken.com
---
þ Synchronet þ electronic chicken bbs - bbs.electronicchicken.com

Re: emailval.js accepts incomplete email addresses
By: Codefenix to Digital Man on Thu Sep 05 2024 08:34 am

Re: emailval.js accepts incomplete email addresses
By: Digital Man to Codefenix on Wed Sep 04 2024 10:05 pm

I don't think that's how that script works though. It doesn't "screen people out" (that provide an invalid email address).

The list of available options in the script's menu imply exactly that.

[S] Send validation code to <email address>
[V] Validate your account
[E] Edit/Update email address
[H] Hangup

If the sysop has the emailval module enabled, it gets called during logon. The user is meant to validate or hit the bricks.

There is no 5th option to proceed unvaliated, otherwise I could agree with you about the script's intent.

Yeah, I'm not familiar with (don't run) that script. I'll take a closer look at it.
--
digital man (rob)

Rush quote #49:
Some will sell their dreams for small desires or lose the race to rats
Norco, CA WX: 104.6øF, 19.0% humidity, 3 mph WNW wind, 0.00 inches rain/24hrs ---
þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net

Re: emailval.js accepts incomplete email addresses
By: Digital Man to Codefenix on Thu Sep 05 2024 12:38 pm

with you about the script's intent.

Yeah, I'm not familiar with (don't run) that script. I'll take a closer look at it.

i think tracker1 wrote it years ago.

it probably would be better to send a user a generated password and disconnect them.
---
þ Synchronet þ ::: BBSES.info - free BBS services :::

Re: emailval.js accepts incomplete email addresses
By: MRO to Digital Man on Thu Sep 05 2024 09:19 pm

it probably would be better to send a user a generated password and disconnect them.

I mean, that's effectively the same thing as what the emailval module currently is doing now, except your approach forces the user to drop and re-connect. emailval keeps the the user on, which I think is preferable.

|01<|09co|03d|11e|15Ÿ|11e|03n|09ix|01>|07


...Fear is no great respecter of reason.
---
þ Synchronet þ -=[ ConstructiveChaos BBS | conchaos.synchro.net ]=-

Re: emailval.js accepts incomplete email addresses
By: Codefenix to MRO on Fri Sep 06 2024 11:02 am

Re: emailval.js accepts incomplete email addresses
By: MRO to Digital Man on Thu Sep 05 2024 09:19 pm

it probably would be better to send a user a generated password and disconnect them.

I mean, that's effectively the same thing as what the emailval module currently is doing now, except your approach forces the user to drop and re-connect. emailval keeps the the user on, which I think is preferable.

depending on where the email comes from, the user could be sitting there for a while if it's being put on hold by the reciever's email provider.
---
þ Synchronet þ ::: BBSES.info - free BBS services :::